Skip to content

Feature/timeline milestone #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
Aug 14, 2018
Merged

Feature/timeline milestone #164

merged 84 commits into from
Aug 14, 2018

Conversation

vikasrohit
Copy link

Merging changes for timeline and milestones in dev
fyi @RishiRajSahu

Vikas Agarwal and others added 30 commits July 11, 2018 13:01
permission fix with unit tests fix
Fixed PATCH endpoint to allow specifying only fields to be updated
…as because we were sending response before transaction commit. Fixed the same for milestone template as well and for update endpoints for milestone and milestone template as well.

Made fields in update call to milestone endpoint, optional so that user can specify only sub set of the fields to be updated.
— Added logic to handle the product as reference for timeline
…nes together

— Implemented the functionality by reading the templateId instead of reading the milestones in the request body. This would make things consistent with the way we are handling project and phases.
— Fixed permission logic for milestones
…efore transaction commit which is causing significant extra time for the transaction to complete which in turn causing other operations of the same table to fail because of table locks.
…fixed before and update is not using transactions as of now which is a separate issue to fix.
- Added connectProjectsUrl config var to test.json, as it's needed for running tests.
… api.

- Added connectProjectsUrl config var to test.json, as it's needed for running tests.
…tes of subsequent milestones.

- Fixed bug where the transaction wasn't being included into wrapped queries.
Vikas Agarwal added 28 commits July 31, 2018 17:54
Also, makes one thing, from status and completionDate, optional to mark a milestone complete
…ading the changes in a milestone

- Should be fixed now
… when they are updated via cascaded changes
Removed code to recalculate the order of the milestones for ES indexing, now it should be carrying those changes to the ES via cascaded updates
…active earlier or later than its scheduled start
…e and endDate so that we can pass them without each other
@vikasrohit vikasrohit merged commit a14b03d into dev Aug 14, 2018
@vikasrohit vikasrohit deleted the feature/timeline-milestone branch August 29, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants